Skip to content

MAINT Update fetch_openml to use the auto parser by default #27802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 20, 2023
Merged

MAINT Update fetch_openml to use the auto parser by default #27802

merged 3 commits into from
Nov 20, 2023

Conversation

ogrisel
Copy link
Member

@ogrisel ogrisel commented Nov 17, 2023

As indicated in the deprecation warning targeting the 1.4 release.

@ogrisel ogrisel added this to the 1.4 milestone Nov 17, 2023
@github-actions GitHub Actions
Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 975eceb. Link to the linter CI: here

@ogrisel
Copy link
Member Author

ogrisel commented Nov 17, 2023

/cc @glemaitre this is the finally fruit of your long term effort :)

@glemaitre glemaitre self-requested a review November 17, 2023 18:38
glemaitre
glemaitre approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do you think that we should be changing the code in the highlights or we let the parser="pandas" in this case?

@glemaitre glemaitre mentioned this pull request Nov 17, 2023
Merged
@ogrisel
Copy link
Member Author

ogrisel commented Nov 20, 2023

LGTM. Do you think that we should be changing the code in the highlights or we let the parser="pandas" in this case?

For old releases highlight, I would leave them unchanged (as long as they work) to convey the original intended meaning of the change at the time.

@lesteve lesteve merged commit 3ab6c8c into scikit-learn:main Nov 20, 2023
@lesteve
Copy link
Member

lesteve commented Nov 20, 2023

Merging, thanks!

@ogrisel ogrisel deleted the fetch_openml-auto-parser branch November 22, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glemaitre glemaitre glemaitre approved these changes

Assignees
No one assigned
Labels
module:datasets No Changelog Needed
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
3 participants
@ogrisel @lesteve @glemaitre