Skip to content

DOC set max_features for HGBT as MajorFeature #27892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2023
Merged

DOC set max_features for HGBT as MajorFeature #27892

merged 1 commit into from
Dec 3, 2023

Conversation

lorentzenchr
Copy link
Member

Reference Issues/PRs

#27139

What does this implement/fix? Explain your changes.

Mark it as MajorFeature.

Any other comments?

@lorentzenchr lorentzenchr added this to the 1.4 milestone Dec 3, 2023
@lorentzenchr
Copy link
Member Author

@glemaitre ping

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2023

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 86c5742. Link to the linter CI: here

glemaitre
glemaitre approved these changes Dec 3, 2023
View reviewed changes
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works with me. LGTM.

@glemaitre glemaitre enabled auto-merge (squash) December 3, 2023 15:32
@glemaitre glemaitre merged commit 522655d into scikit-learn:main Dec 3, 2023
@lorentzenchr lorentzenchr deleted the hgbt_max_features_major_feature branch December 3, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glemaitre glemaitre glemaitre approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
2 participants
@lorentzenchr @glemaitre