Skip to content

clarifies brief description of Transformer API #27901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2023
Merged

clarifies brief description of Transformer API #27901

merged 1 commit into from
Dec 4, 2023

Conversation

jmmcd
Copy link
Contributor

@jmmcd jmmcd commented Dec 4, 2023

As requested in #27900

I've removed the term "filtering" - to some people it might include removing columns, but to me (influenced by SQL) I think filtering only refers to rows. The new message is unambiguous without this term.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 0ca1241. Link to the linter CI: here

glemaitre
glemaitre approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @jmmcd

@glemaitre glemaitre merged commit 7e9e9be into scikit-learn:main Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glemaitre glemaitre glemaitre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmmcd @glemaitre