Skip to content

Conversation

glemaitre
Copy link
Member

Fixing the changelog to prepare the release:

  • respect the tag order
  • create a section for the array api to make it easy to know what is supported
  • just some nitpics impacting only the rst file

@glemaitre glemaitre added the Quick Review For PRs that are quick to review label Dec 11, 2023
@glemaitre glemaitre added this to the 1.4 milestone Dec 11, 2023
Copy link

github-actions bot commented Dec 11, 2023

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: cf216b9. Link to the linter CI: here

Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM. Thanks @glemaitre

Several estimators and functions support the
`Array API <https://data-apis.org/array-api/latest/>`_. Such changes allows for using
the estimators and functions with other libraries such as JAX, CuPy, and PyTorch.
It therefore enable for some GPU-accelerated computations.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe

This therefore enables some GPU-accelerated computations.

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan merged commit 6291f66 into scikit-learn:main Dec 11, 2023
glemaitre added a commit to glemaitre/scikit-learn that referenced this pull request Feb 10, 2024
Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Quick Review For PRs that are quick to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants