DOC Add note in Array API doc regarding support for devices without float 64 support #28034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemaitre
approved these changes
Jan 12, 2024
| a transfer to CPU. | ||
|
|
||
| Minimizing the usage of float64 upcasting in scikit-learn is an open improvement | ||
| direction, to maybe yield better performance from devices that do not support it, |
There was a problem hiding this comment.
Suggested change
| direction, to maybe yield better performance from devices that do not support it, | |
| direction, to yield better performance from devices that do not support it, |
There was a problem hiding this comment.
Oh actually, I wanted to remove the "maybe"
There was a problem hiding this comment.
I can't reconstruct what I meant to say. Reading my comment now I am confused.com about what I was trying to say (it seems like a comment written while distracted) :-/
Let's ignore it?
Co-authored-by: Guillaume Lemaitre <guillaume@probabl.ai>
|
I've applied all the suggestions. I think they are uncontroversial typo fixes. The one I didn't apply is because I don't think it makes sense. @glemaitre maybe you can take another look and then merge? |
glemaitre
approved these changes
Feb 19, 2024
|
I'm still +1 until that this actually the policy that we use. It seems that it was questioned in this PR: #27904 (comment) I would delay a merge until we settle on the matter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Adds a note in the array api documentation that documents scikit-learn policy regarding support of devices that do not support float64 precision operations. (basically stating that it favors consistency with CPU behavior at the cost of data transfers to CPU, over remaining on the device at the cost of capping compute to highest supported precision)
Discuted before with @betatim and @ogrisel , in particular during review of #27904