add dbcv score (unsupervised clustering score) and one test comparing kmeans and dbscan dbcv score #28036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I only added the new dbcv_score into the changelog v1.4 as a feature, tell me if I should also add the helper functions. |
adrinjalali
reviewed
Jan 2, 2024
doc/whats_new/v1.4.rst
Outdated
Comment on lines
610
to
611
| - |Feature| :func:`metrics.cluster.dbcv_score` | ||
| :pr:`28036` by :user:`Nils Cercariolo <Nylio-prog>`. |
There was a problem hiding this comment.
needs to be in the 1.5 changelog.
|
This is not really a good first issue to try really. Please try one of the issues labeled as good first issue to get used to the workflow here. |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #27259
What does this implement/fix? Explain your changes.
This adds the dbcv score which is a density based score for unsupervised clustering. I've also included one test that compares kmeans and dbscan's dbcv scores with the moon dataset. This follows this paper.
Any other comments?
I wasn't sure where to add all the helper functions for dbcv score as it is a bit more complex than other metrics so I added another file but feel free to propose other options as it is my first PR. The implementation follows closely this repo.