Skip to content

CI Fix assign/unassign workflow #28044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

thomasjpfan
Copy link
Member

Reference Issues/PRs

Follow up to #28031

What does this implement/fix? Explain your changes.

This PR fixes a few issues gh with the GitHub Actions.

Any other comments?

REF: https://docs.github.com/en/actions/using-workflows/using-github-cli-in-workflows

Copy link

github-actions bot commented Jan 2, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 33a2d0d. Link to the linter CI: here

@thomasjpfan thomasjpfan added the Quick Review For PRs that are quick to review label Jan 2, 2024
Copy link
Member Author

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This time, I properly tested this PR out on my fork, which gave me some errors.

CC @lesteve

gh issue edit $ISSUE --remove-label "help wanted"
env:
GH_TOKEN: ${{ github.token }}
ISSUE: ${{ github.event.issue.html_url }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

html_url is required because the repo is not checked in, so gh needs to the full url to point to the issue.

Copy link
Member

@lesteve lesteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lesteve lesteve enabled auto-merge (squash) January 2, 2024 13:57
@lesteve lesteve merged commit 9da38ba into scikit-learn:main Jan 2, 2024
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Jan 17, 2024
jeremiedbb pushed a commit that referenced this pull request Jan 17, 2024
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build / CI Quick Review For PRs that are quick to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants