Skip to content

FIX dump svmlight when data is read-only #28111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 13, 2024
Merged

FIX dump svmlight when data is read-only #28111

merged 5 commits into from
Jan 13, 2024

Conversation

Charlie-XIAO
Copy link
Contributor

Fixes #28026.

The original signature would raise ValueError: buffer source array is read-only if X is for instance memmap-based.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 12, 2024 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: ef02752. Link to the linter CI: here

@Charlie-XIAO Charlie-XIAO mentioned this pull request Jan 12, 2024
Closed
@glemaitre glemaitre self-requested a review January 13, 2024 11:34
glemaitre
glemaitre approved these changes Jan 13, 2024
View reviewed changes
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Charlie-XIAO. LGTM on my side.

@glemaitre glemaitre added Quick Review For PRs that are quick to review Waiting for Second Reviewer First reviewer is done, need a second one! labels Jan 13, 2024
@jjerphan jjerphan merged commit f48ee39 into scikit-learn:main Jan 13, 2024
@Charlie-XIAO Charlie-XIAO deleted the dump-svmlight-read-only branch January 13, 2024 14:42
@jeremiedbb jeremiedbb added the To backport PR merged in master that need a backport to a release branch defined based on the milestone. label Jan 17, 2024
@jeremiedbb jeremiedbb added this to the 1.4 milestone Jan 17, 2024
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Jan 17, 2024
@Charlie-XIAO @glemaitre @jeremiedbb
FIX dump svmlight when data is read-only (scikit-learn#28111)
a49e70b 
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
jeremiedbb pushed a commit that referenced this pull request Jan 17, 2024
@Charlie-XIAO @glemaitre @jeremiedbb
FIX dump svmlight when data is read-only (#28111)
019d329 
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
glemaitre added a commit to glemaitre/scikit-learn that referenced this pull request Feb 10, 2024
@Charlie-XIAO @glemaitre
FIX dump svmlight when data is read-only (scikit-learn#28111)
c92f9d0 
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glemaitre glemaitre glemaitre approved these changes

@jjerphan jjerphan jjerphan approved these changes

Assignees
No one assigned
Labels
cython module:datasets Quick Review For PRs that are quick to review To backport PR merged in master that need a backport to a release branch defined based on the milestone. Waiting for Second Reviewer First reviewer is done, need a second one!
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.

ValueError: buffer source array is read-only in check_estimator
4 participants
@Charlie-XIAO @glemaitre @jjerphan @jeremiedbb