Skip to content

MNT bump to cython=3.0.8 #28284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 31, 2024
Merged

MNT bump to cython=3.0.8 #28284

merged 4 commits into from
Jan 31, 2024

Conversation

adrinjalali
Copy link
Member

@adrinjalali adrinjalali commented Jan 26, 2024 •
edited
Loading

Closes #28259

Updates min required version of cython to 3.0.8

On conda default channels, we use pip to install cython since the latest available version there is 3.0.6

cc @lesteve

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 26, 2024 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: d5e68f2. Link to the linter CI: here

@adrinjalali
Copy link
Member Author

depends on #28258

@adrinjalali adrinjalali mentioned this pull request Jan 27, 2024
Closed
@jjerphan jjerphan mentioned this pull request Jan 29, 2024
Closed
@adrinjalali
Copy link
Member Author

@glemaitre @lesteve it's green 😁

glemaitre
glemaitre approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from the point raised by @lesteve regarding breaking nogil. It might be OK if we want to be able to solve some issues in the TargetEncoder.

@lesteve lesteve merged commit 544394d into scikit-learn:main Jan 31, 2024
@adrinjalali adrinjalali deleted the cython-3 branch January 31, 2024 18:47
@lesteve
Copy link
Member

lesteve commented Jan 31, 2024 •
edited
Loading

I am just going to pretend that I did not see that we did not test "special" as in "non-main" CIs (scipy-dev, pypy, arm, nogil) 😉

This was referenced Feb 1, 2024
Merged
Closed
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Feb 10, 2024
@adrinjalali @glemaitre
MNT bump to cython=3.0.8 (scikit-learn#28284)
7e9ba51
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Feb 13, 2024
@adrinjalali @glemaitre
MNT bump to cython=3.0.8 (scikit-learn#28284)
6b35e68
glemaitre pushed a commit that referenced this pull request Feb 13, 2024
@adrinjalali @glemaitre
MNT bump to cython=3.0.8 (#28284)
fd49d87
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesteve lesteve lesteve approved these changes

@glemaitre glemaitre glemaitre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RFC bump Cython minimum supported version to 3.0.8
3 participants
@adrinjalali @lesteve @glemaitre