Skip to content

DOC fix a sphinx warning and a rendering issue #28315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

Charlie-XIAO
Copy link
Contributor

sklearn.utils.validation: A missing line between the newly added example section and the previous section.

doc/roadmap.rst: I spent quite some time to find out why this file failed to render correctly with pydata-sphinx-theme. When I checked the HTML I found something like <p>&#xFEFF;.. _roadmap:</p>, which is the zero-width no-break space. Not sure why but seems that the file was saved as UTF8 with BOM, and resaving as UTF8 solves the problem.

Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 0efc574. Link to the linter CI: here

@adrinjalali adrinjalali merged commit a3f8e6d into scikit-learn:main Jan 31, 2024
@adrinjalali
Copy link
Member

and pushed to branch.

@Charlie-XIAO
Copy link
Contributor Author

Thanks very much!

@Charlie-XIAO Charlie-XIAO deleted the doc-sphinx-warn branch January 31, 2024 10:18
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Feb 10, 2024
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants