Skip to content

CI Fix following scipy dev coo_matrix attr renaming #28374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

lesteve
Copy link
Member

@lesteve lesteve commented Feb 6, 2024

Seen in #28372. Closes #28357.

The .indices -> .coords attr renaming was done in scipy/scipy#20003.

Copy link

github-actions bot commented Feb 6, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: cd8305a. Link to the linter CI: here

Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm when CI is green (codecov)

@lesteve
Copy link
Member Author

lesteve commented Feb 7, 2024

I restarted the build with codecov failing and CI is green. Merging my own PR with 1 approval.

@lesteve lesteve merged commit 7152419 into scikit-learn:main Feb 7, 2024
@lesteve lesteve deleted the fix-scipy-dev branch February 7, 2024 05:36
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Feb 10, 2024
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

⚠️ CI failed on Linux_Nightly.pylatest_pip_scipy_dev ⚠️
2 participants