Skip to content

MAINT remove unneeded robots.txt #28387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

Charlie-XIAO
Copy link
Contributor

@Charlie-XIAO Charlie-XIAO commented Feb 8, 2024

The file was added by #28376 but is not taking effect because it will be uploaded to this location: https://github.com/scikit-learn/scikit-learn.github.io/blob/main/dev/robots.txt

The workaround is scikit-learn/scikit-learn.github.io#21 so we no longer need to robots.txt now.

@lesteve

@Charlie-XIAO Charlie-XIAO changed the title MAINT remove the redundant robots.txt MAINT remove the redundant robots.txt Feb 8, 2024
Copy link

github-actions bot commented Feb 8, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 816ff0b. Link to the linter CI: here

@lesteve lesteve enabled auto-merge (squash) February 8, 2024 15:19
@lesteve lesteve changed the title MAINT remove the redundant robots.txt MAINT remove unneeded robots.txt Feb 8, 2024
Copy link
Member

@lesteve lesteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for following up on this!

@lesteve
Copy link
Member

lesteve commented Feb 8, 2024

I have enabled auto-merge so this will be merged when CI is green

@glemaitre glemaitre disabled auto-merge February 8, 2024 16:59
@glemaitre glemaitre enabled auto-merge (squash) February 8, 2024 17:00
@glemaitre
Copy link
Member

We are not lucky that the required steps are failing because of codecov and thus we have no real way to merge PR :)

@lesteve
Copy link
Member

lesteve commented Feb 8, 2024

We are not lucky that the required steps are failing because of codecov and thus we have no real way to merge PR :)

The timing is not great indeed, codecov issues started happening right after we disable "Bypass checks". This seems like a test of our motivation 😅

I reran the failing build

@glemaitre glemaitre merged commit d54d7a2 into scikit-learn:main Feb 8, 2024
@Charlie-XIAO Charlie-XIAO deleted the remove-robots branch February 8, 2024 23:46
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Feb 10, 2024
LeoGrin pushed a commit to LeoGrin/scikit-learn that referenced this pull request Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants