CI Adds environment to upload_anaconda #28441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lesteve
approved these changes
Feb 17, 2024
There was a problem hiding this comment.
LGTM, thanks for looking into this!
I guess we will be able to remove the identically named repository secrets once this PR is merged?
|
There is probably some clean-up that we can do in the repository secrets already, for example we could remove the PyPI upload token if we are not using it anymore according to #24491 (comment) |
thomasjpfan
added a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Feb 17, 2024
lesteve
pushed a commit
that referenced
this pull request
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Related to #24491 (comment)
What does this implement/fix? Explain your changes.
I added a new
upload_anacondaenvironment to the repo: https://github.com/scikit-learn/scikit-learn/settings/environments with the tokens for uploading to anaconda.With environments, the only GitHub jobs marked with
environment: upload_anacondacan have access to the secrets.CC @lesteve