CI Adds environment for publishing to pypi #28445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lesteve
approved these changes
Feb 19, 2024
thomasjpfan
added a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Feb 19, 2024
lesteve
pushed a commit
that referenced
this pull request
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For publishing to PyPI, the Trusted Publisher docs recommends placing the workflow in an environment. I already created the
publish_pypienvironment in this repo.After this is merged and backported to
1.4.X, I'll update the PyPI config to only allow uploads from this environment.CC @lesteve
For completeness here is what the Trusted Publisher PyPI doc says: