-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
DOC [PST] tune FAQ page styling #28448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Just to confirm @ogrisel, do you mean that we should keep the |
ping @ogrisel |
Yes. But if that's too cumbersome/hackish to implement let's keep it the way it is in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I would have preferred to keep the toctree at the top of the page though (as explained in #28448 (review)), but I am fine with the current state of this PR. I let you and the second reviewer decide :)
Thanks for the clarification @ogrisel. AFAIK there is not an option of the |
I think I do miss the ToC on top of the page. I personally wouldn't mind having the ToC on top, AND have the usual pydata theme navbar on the right side. Would that be okay? |
@adrinjalali Yes that's perfectly okay. The tradeoff is in fact "keeping the TOC at the top of the page" will cause "backlinks to be generated for the titles which does not look good". I however made a mistake in the previous comment: the statement there is no trivial way to remove backlink styles is incorrect. In CSS there are Well anyways, I think the latest version would resolve all the mentioned problems. Also ping @ogrisel if you want to take another look. https://output.circle-artifacts.com/output/job/f3d31074-de89-4934-8c65-c1c8bbe171c2/artifacts/0/doc/faq.html |
I think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with or without the pointer-events
rule.
On second thought I agree. Now I only kept |
Please note that this PR targets the
new_web_theme
branch!Towards #28084. This PR:
.. toctree::
in the page so that the question headings do not become (meaningless, in the sense that we have the secondary sidebar) links.h3
headings) rubric-like; this is personal taste so please let me know if maintainers think the original style is better.