Skip to content

DOC Use effective value for max_iter in BayesianRidge and ARDRegression #28476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 20, 2024
Merged

DOC Use effective value for max_iter in BayesianRidge and ARDRegression #28476

merged 1 commit into from
Feb 20, 2024

Conversation

lucyleeow
Copy link
Member

Reference Issues/PRs

Noticed in: #28471 (comment)

What does this implement/fix? Explain your changes.

Use effective value for max_iter, instead of None then explaining that None effectively means 300. This is done elsewhere #28471 (comment)

Any other comments?

cc @betatim

@lucyleeow lucyleeow changed the title DOC Use effective value for max_iter in docstring DOC Use effective value for max_iter in BayesianRidge and ARDRegression Feb 20, 2024
@lucyleeow lucyleeow added the Quick Review For PRs that are quick to review label Feb 20, 2024
@github-actions GitHub Actions
Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 2a54c5b. Link to the linter CI: here

betatim
betatim approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@betatim betatim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for me. Let's see if someone else has opinions (that go the other way)

jeremiedbb
jeremiedbb approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM since None is just there for the duration of the deprecation of n_iter.

@jeremiedbb jeremiedbb merged commit ec0ca96 into scikit-learn:main Feb 20, 2024
@lucyleeow lucyleeow deleted the bayes_default branch February 21, 2024 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betatim betatim betatim approved these changes

@jeremiedbb jeremiedbb jeremiedbb approved these changes

Assignees
No one assigned
Labels
Documentation module:linear_model Quick Review For PRs that are quick to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucyleeow @betatim @jeremiedbb