DOC Update hgbt docstrings on categorical_features default value #28485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
"warn" is just there during the deprecation cycle, but falls back to |
|
I see. Then I guess I misunderstood Olivier's comment! 😅 Closing this one! |
|
Olivier's comment was about "by_dtype" which is the effective value. But we'll do the change in the docstring in 1.6 when the default value actually change to "by_dtype". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
In #26411 we added the option the support of
categorical_features="from_dtype".As mentioned in #26411 (comment), the docstrings need to be updated accordingly. It's still written default=None.
What does this implement/fix? Explain your changes.
This PR fixes the issue.
Any other comments?