MAINT cleanup utils.__init__: move openblas check into fixes #28486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto cln_utils_fixes
jjerphan
approved these changes
Feb 22, 2024
|
We're leaking quite a few imports in our |
|
Well we can't guarantee stability of internal stuff, whether it's function names, signature, behavior or location. Third party packages should not rely on those and if they do anyway it's expected that it will break every once in a while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #26686 to ease the reviews. The end goal is to clean the utils.init.py module as explained in the linked PR.
I wasn't sure where to put
_in_unstable_openblas_configurationbut inutils.fixesseems acceptable since it concerns an issue in a specific version of a dependency that will disappear at some point.