MAINT cleanup utils.__init__: move nan utils into dedicated submodule #28495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #26686 to ease the reviews. The end goal is to clean the utils.init.py module as explained in the linked PR.
I didn't find a relevant already existing module to move
is_scalar_nanand_is_pandas_nainto so I created a dedicatedutils._missingsubmodule. Maybe it could go intovaildationsince it's kind of related to input/data validation but I not sure if it's the right place, let me know what you think.Since both function are not listed in
classes.rst, they're assumed private so I made them only importable from utils._missing.I also took the opportunity to rename
_is_pandas_naintois_pandas_nasince there's no need to multiply the leading underscores: it already comes from a private module.