DOC [PST] FIX/RFC machine learning map #28630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 tasks
thomasjpfan
reviewed
Mar 14, 2024
|
This is not desired. Sadly I think Edit: I think I've figured out a way to limit the pan. I will update when I get some time to test. |
|
Okay so this new version limits the pan. It relies on Choosing.the.right.estimator.scikit-learn.1.5.dev0.documentation.8.-.-.Microsoft.Edge.2024-03-15.20-38-20.mp4 |
adrinjalali
approved these changes
Apr 23, 2024
thomasjpfan
reviewed
Apr 29, 2024
|
License added! |
thomasjpfan
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note that this PR targets the
new_web_themebranch!Towards #28084. Check the rendered docs here.
Prior to this PR the machine learning map is a PNG image and the links on the nodes are realized using the
<map>component. However the<map>requires hard-coded positions and will not automatically scale as the width and height of the image changes. The only way is to usetransform: scale(xxx). The problem with this is:transformdoes not change width and height so the image will still take up that much space on the page. The solution prior to this PR was to useposition: absolutebut this will breakpydata-sphinx-theme.The solution of this PR is to use SVG+XML, which natively allows links so there is no need for
<map>and no problem of image scaling. The chart is created using draw.io, and to modify the chart one simplify import the chart into draw.io, make changes, and re-export.This PR also supports zoom on wheel and pan on drag when JavaScript is available using svg-pan-zoom-container. It also supports dark mode by inverting the colors and rotating the hues.
I've tried my best to simulate the original chart. The nodes and their layout are also the same, but I don't know how to create irregular shapes in draw.io so I used the rounded rectangles for the four main blocks instead.
Choosing.the.right.estimator.scikit-learn.1.5.dev0.documentation.9.-.-.Microsoft.Edge.2024-03-15.02-44-49.mp4