-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
MNT bump to Cython=3.0.9 #28640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNT bump to Cython=3.0.9 #28640
Conversation
Out of curiosity, is this useful or needed for a specific PR/issue?
I don't want to force contributors to always upgrade to the latest version of Cython if they don't need to. EDIT: this change is mandated by #28603 although it's net yet obvious to me which part of this PR requires the Cython version bump. |
Also side-comment, note that the nogil build needs some coordination work with Sam Gross, if we update the min Cython dependency, see for example colesbury/nogil-wheels#6. For now the nogil lock-file is updated manually outside of the |
It‘s required for a bugfix of fused types used in a method of a cython.final extension type. |
I resolved the conflict. Let me do a re-run of the update lock file script just to be sure. If everything is green, I am fine with merging this version update if it makes it easier for other concurrent PRs on HGBDT. |
Actually, let's wait for #28653 and then re-run the lock script on this PR. EDIT: fixed PR number. |
For reference, I opened the PR to build the Cython 3.0.9 wheel for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed a commit to trigger all the CIs with the new Cython version.
Assuming this is green, +1 on my side.
I opened #28654 to update the |
#28555 was merged and some of the lock files need another update as a consequence. Let me push another commit. |
@ogrisel Thanks for taking over! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merging, thanks! |
Reference Issues/PRs
None
What does this implement/fix? Explain your changes.
Updates min required version of cython to 3.0.9.
Any other comments?