Skip to content

TST: missing test for unsigned integers types in _typedefs.pxd #28657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2024
Merged

TST: missing test for unsigned integers types in _typedefs.pxd #28657

merged 1 commit into from
Mar 19, 2024

Conversation

ogrisel
Copy link
Member

@ogrisel ogrisel commented Mar 19, 2024 •
edited
Loading

To settle the discussion in #25572 (comment) to prepare a review of #28656.

@ogrisel ogrisel added module:test-suite everything related to our tests No Changelog Needed cython labels Mar 19, 2024
@github-actions GitHub Actions
Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 3aa22df. Link to the linter CI: here

lorentzenchr
lorentzenchr approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@lorentzenchr lorentzenchr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you alphabetically sort the test entries? Or feel free to merge.

adam2392
adam2392 approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@adam2392 adam2392 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ogrisel ogrisel merged commit 69c1116 into scikit-learn:main Mar 19, 2024
@ogrisel ogrisel deleted the test-uint32_t-typedef branch March 19, 2024 13:18
@ogrisel
Copy link
Member Author

ogrisel commented Mar 19, 2024

Could you alphabetically sort the test entries? Or feel free to merge.

I merged because I don't like having uint8_t after uint64_t. At least now all the integers are grouped together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesteve lesteve lesteve approved these changes

@adam2392 adam2392 adam2392 approved these changes

@lorentzenchr lorentzenchr lorentzenchr approved these changes

Assignees
No one assigned
Labels
cython module:test-suite everything related to our tests module:utils No Changelog Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ogrisel @lesteve @adam2392 @lorentzenchr