Skip to content

MAINT cleanup utils.__init__: move _to_object_array into utils.validation #28661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 28, 2024
Merged

MAINT cleanup utils.__init__: move _to_object_array into utils.validation #28661

merged 2 commits into from
Mar 28, 2024

Conversation

jeremiedbb
Copy link
Member

Extracted from #26686 to ease the reviews. The end goal is to clean the utils.__init__ module as explained in the linked PR.

Move _to_object_array into utils.validation.

@jeremiedbb jeremiedbb added No Changelog Needed Quick Review For PRs that are quick to review labels Mar 19, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 19, 2024 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 13cf2c8. Link to the linter CI: here

thomasjpfan
thomasjpfan approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am okay with moving it to validation. Although, the only non-test usage of _to_object_array is in neighbors._base. I am okay with moving _to_object_array to neighbors._base as well.

glemaitre
glemaitre approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well. Thanks @jeremiedbb

@glemaitre
Copy link
Member

Whoops, I did not wanted to trigger requesting a review from @thomasjpfan. Sorry about that.
Enabling auto-merge. Thanks @jeremiedbb

@glemaitre glemaitre enabled auto-merge (squash) March 28, 2024 07:01
@glemaitre glemaitre merged commit 9926887 into scikit-learn:main Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan Awaiting requested review from thomasjpfan

@glemaitre glemaitre Awaiting requested review from glemaitre

Assignees
No one assigned
Labels
module:neighbors module:preprocessing module:utils No Changelog Needed Quick Review For PRs that are quick to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeremiedbb @glemaitre @thomasjpfan