Skip to content

DOC linked isotonic regression example to isotonic regression doc #28673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 25, 2024
Merged

DOC linked isotonic regression example to isotonic regression doc #28673

merged 3 commits into from
Mar 25, 2024

Conversation

Dev-Akash
Copy link
Contributor

Reference Issues/PRs

Issue #26927

What does this implement/fix? Explain your changes.

This PR add link in doc/Module/Isotonic for example of isotonic regression - miscellaneous/plot_isotonic_regression.py

Any other comments?

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 21, 2024 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: e328660. Link to the linter CI: here

ogrisel
ogrisel reviewed Mar 21, 2024
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Please consider the comment/suggestion below:

@Dev-Akash @ogrisel
Update doc/modules/isotonic.rst
5bf7f97 
Added suggested changes

Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
@Dev-Akash
Copy link
Contributor Author

Hi @ogrisel,
Thanks for suggesting a better change. I have added those changes.
Please review and consider the PR.
Thank you!

ArturoAmorQ
ArturoAmorQ approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@ArturoAmorQ ArturoAmorQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Dev-Akash, LGTM as it is. Merging!

@ArturoAmorQ ArturoAmorQ merged commit d301cb0 into scikit-learn:main Mar 25, 2024
30 checks passed
@ArturoAmorQ ArturoAmorQ mentioned this pull request Mar 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@ArturoAmorQ ArturoAmorQ ArturoAmorQ approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dev-Akash @ogrisel @ArturoAmorQ