-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
MAINT avoid fetching lfw datasets when SKLEARN_SKIP_NETWORK_TESTS=1 #28709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ping @jeremiedbb @lesteve since you already know about the issue. It should be a quick fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The docstring tests of fetch_lfw_xxx no longer appear in the slowest tests report.
Which is weird cause the |
The code is not that easy to follow ... I am not 100% sure, but I think this change has the side effect to download more datasets than previously when running network cases in some cases e.g. when not running doctests. Is it really important, probably not?
Network tests are run only on scheduled runs. I don't remember why exactly but I was involved in this change (maybe there were previously run during scipy-dev tests and it was annoying for some reason) ... Edit: #28383 there was some mysterious slowness of dataset downloads inside pytest when moving the scipy-dev from Python 3.11 to Python 3.12 ... |
Oh right, I read too quickly |
I don't think there are cases where we enable network tests but disable docstring tests, so I think it's fine to merge as is and not bother too much |
OK let's merge this one then! |
closes #28707
Avoid fetching LFW datasets if network is disabled.