Skip to content

CI Use check-sdist to check sdist rather than check-manifest #28757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 9, 2024
Merged

CI Use check-sdist to check sdist rather than check-manifest #28757

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
62204bd
CI Use check-sdist to check sdist rather than check-manifest
lesteve Apr 3, 2024
39fcd7e
Trigger CI
lesteve Apr 3, 2024
aaa4b3e
Mirror closer setup.py sdist content
lesteve Apr 4, 2024
e7ae1cd
Merge branch 'main' of https://github.com/scikit-learn/scikit-learn i…
lesteve Apr 4, 2024
d0005b9
[pyodide] Trigger CI
lesteve Apr 4, 2024
8354d5f
No need to install build deps + add --inject-junk
lesteve Apr 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .gitattributes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
.* export-ignore
asv_benchmarks export-ignore
azure-pipelines.yml export-ignore
benchmarks export-ignore
build_tools export-ignore
maint_tools export-ignore
12 changes: 6 additions & 6 deletions .github/workflows/check-manifest.yml → .github/workflows/check-sdist.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
name: "Check Manifest"
name: "Check sdist"

on:
schedule:
- cron: '0 0 * * *'

jobs:
check-manifest:
check-sdist:
# Don't run on forks
if: github.repository == 'scikit-learn/scikit-learn'

Expand All @@ -19,15 +19,15 @@ jobs:
# scipy and cython are required to build sdist
run: |
python -m pip install --upgrade pip
pip install check-manifest scipy cython
pip install check-sdist
- run: |
check-manifest -v
check-sdist --inject-junk

update-tracker:
uses: ./.github/workflows/update_tracking_issue.yml
if: ${{ always() }}
needs: [check-manifest]
needs: [check-sdist]
with:
job_status: ${{ needs.check-manifest.result }}
job_status: ${{ needs.check-sdist.result }}
secrets:
BOT_GITHUB_TOKEN: ${{ secrets.BOT_GITHUB_TOKEN }}
6 changes: 6 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,3 +203,9 @@ exclude= '''
| sklearn/metrics/_pairwise_distances_reduction/_radius_neighbors.pyx
)
'''

[tool.check-sdist]
# These settings should match .gitattributes
sdist-only = []
git-only = [".*", "asv_benchmarks", "azure-pipelines.yml", "benchmarks", "build_tools", "maint_tools"]
default-ignore = false
Loading