Skip to content

CI Use Meson for Pyodide build #28845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

CI Use Meson for Pyodide build #28845

wants to merge 2 commits into from

Conversation

lesteve
Copy link
Member

@lesteve lesteve commented Apr 16, 2024 •
edited
Loading

I took the meson cross-compilation file from Numpy numpy/numpy#25894 and numpy/numpy#24603.

I have triggered a Pyodide build to see whether that passes.

Edit: Meson is indeed used for building see build log

+ meson setup /home/vsts/work/1/s /home/vsts/work/1/s/.mesonpy-379d495u -Dbuildtype=release -Db_ndebug=if-release -Db_vscrt=md --cross-file=/home/vsts/work/1/s/build_tools/azure/emscripten.meson.cross --native-file=/home/vsts/work/1/s/.mesonpy-379d495u/meson-python-native-file.ini
The Meson build system
Version: 1.4.0

@lesteve lesteve changed the title Meson for pyodide build CI Use Meson for pyodide build Apr 16, 2024
@github-actions GitHub Actions
Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: d03bc1d. Link to the linter CI: here

@lesteve lesteve changed the title CI Use Meson for pyodide build CI Use Meson for Pyodide build Apr 16, 2024
@lesteve
Copy link
Member Author

lesteve commented Apr 16, 2024

Hmmm actually closing this one, since Meson is already being used on main without having to provide a cross file, see scheduled build from build log ... I am pretty sure I checked at some point and it was still using setuptools but maybe this changed since we switched to Pyodide 0.25.

@lesteve lesteve closed this Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Build / CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lesteve