ENH Add missing base.is_clusterer() function
#28936
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrinjalali
approved these changes
May 6, 2024
|
Needs a changelog introducing the new function. |
Thanks for the hint. Added to changelog... |
|
BTW: I added this new function to the changelog of version 1.5. |
|
Yes, the changelog would need to be moved. |
Was necessary to get the 1.6 changelog file
|
Moved the changelog entry from version 1.5 to 1.6. |
glemaitre
reviewed
May 17, 2024
glemaitre
reviewed
May 17, 2024
glemaitre
reviewed
May 20, 2024
To get the doc/api_reference.py file
glemaitre
reviewed
May 21, 2024
glemaitre
approved these changes
May 21, 2024
|
Do we need the |
glemaitre
reviewed
May 21, 2024
|
LGTM, I'm enabling auto-merge. Thanks @ChVeen! |
Charlie-XIAO
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #28960
What does this implement/fix? Explain your changes.
This PR proposes to add the missing
base.is_clusterer()function analogously tobase.is_classifier().There is a user demand for this as can be seen in discussion #28904.
The missing unit test for
base.is_regressor()is added as well.Any other comments?