FIX ‘sparse’ kwarg was not used by fowlkes_mallows_score #28981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prabashbala
reviewed
May 9, 2024
adrinjalali
reviewed
Aug 13, 2024
| @@ -1181,7 +1181,7 @@ def normalized_mutual_info_score( | |||
| }, | |||
| prefer_skip_nested_validation=True, | |||
| ) | |||
| def fowlkes_mallows_score(labels_true, labels_pred, *, sparse=False): | |||
| def fowlkes_mallows_score(labels_true, labels_pred, *, sparse=True): | |||
There was a problem hiding this comment.
I wouldn't change the default here though.
|
Setting Instead of "making this keyword argument work" I think it makes sense to "remove his keyword argument". It is not used, has not been used and provides no advantages. |
|
That's true, the code actually relies on the output (c) being sparse. So we can deprecate the parameter here. |
jeremiedbb
approved these changes
Apr 16, 2025
adrinjalali
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
No issue.
What does this implement/fix? Explain your changes.
The function sklearn.metrics.fowlkes_mallows_score was defined with:
but the code never uses sparse. The parameter sparse should have been passed to contingency_matrix, but instead we currently see a few lines later:
This commit fixes the inconsistency by:
Any other comments?
The function sklearn.metrics.fowlkes_mallows_score has never been tested with sparse=False, it might be good to have a few tests for that use case too?