CI Fix wheel builder windows #29006
Merged
CI Fix wheel builder windows #29006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremiedbb
commented
May 13, 2024
Comment on lines
-56
to
-57
| # Note: windows-2019 is needed for older Python versions: | ||
| # https://github.com/scikit-learn/scikit-learn/issues/22530 |
There was a problem hiding this comment.
unrelated but this comment is outdated
lesteve
approved these changes
May 13, 2024
ogrisel
approved these changes
May 13, 2024
There was a problem hiding this comment.
At some point we will tooling to update and pin specific versions of all wheel building dependencies to enable build reproducibility but let's address that in a set of specific PRs related to #28151 once we decide to seriously allocate resources to tackle this issue.
jeremiedbb
added a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
May 20, 2024
jeremiedbb
added a commit
that referenced
this pull request
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29002