-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
MNT Use c11 rather than c17 in meson.build to work-around Pyodide issue #29015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the time being assuming this is good enough for building scikit-learn against the free-threading version of CPython 3.13b1.
Yes, C11 is fine, scikit-learn builds successfully under the free-threaded build with this PR checked out. To be clear, the specific issue we're working around is there's a That said, all the compilers Python supports should also build with the C11 standard, so it should be safe to update this as long as pyiodide is OK with it. |
Thanks very much for taking the time to write this explanation @ngoldbaum. |
See discussion on scikit-learn#29015 and scikit-learn#28980
Fix #29013