-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
DOC final cleanup for switching to pydata-sphinx-theme
#29037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC final cleanup for switching to pydata-sphinx-theme
#29037
Conversation
@glemaitre @adrinjalali I think this is ready for review. I briefly went through the website and did not see fundamental problems. After the new web theme is deployed, I may:
Please feel free to navigate through the built artifact and let me know if there are problems that I overlooked. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LTGM
I'm fine that we have a couple of glitches that will be removed soonish. |
FYI, we should not block the merge of this PR regarding this #29037 (comment) This can be tackled in a subsequent PR and I think that this is more valuable to have the website ready for 1.5 |
Sure (I'm sorry I wasn't at home so did not provide a timely update). Then shall we merge this one rn then I can quickly update #29038 to get the website ready? |
Don't worry, I'll ping a second reviewer but I'm sure that we will be able to do it for 1.5 :) |
I just realized that I forgot "not" in my previous sentence. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes here look fine, but I haven't been following this closely so I can't tell if it's missing something
There might be something wrong here: has this PR deleted |
It was done on purpose. It's now listed in |
Nop, now this file is generated with the |
Oh, I see then. Sorry, it seems I was looking for it to show up in some diff in the wrong place. |
Note that this PR targets the
new_web_theme
branch!Towards #28084.
doc-min-dependency
workflowGallery index page links not tweaked (don't think this is needed)Some images are going wrong (cannot be found) (no issues whenmake html
)Some API examples are going wrong (looks like my local issues)(Maybe) wait forpydata-sphinx-theme
0.15.3 (prerelease is already there so maybe the release will come soon?) (no need to do so, after all the website will automatically be updated when that release comes toconda-forge
)The places marked with
TODO(new_web_theme)
are to be resolved in #29038 after this one is merged.