Skip to content

FIX workaround to remove the left sidebar on some page #29047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 19, 2024
Merged

FIX workaround to remove the left sidebar on some page #29047

merged 3 commits into from
May 19, 2024

Conversation

glemaitre
Copy link
Member

I think that we can go around the issue reported here: pydata/pydata-sphinx-theme#1662

We can suppress the left sidebar with the following configuration.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 18, 2024 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 4169266. Link to the linter CI: here

@glemaitre
Copy link
Member Author

ping @Charlie-XIAO @adrinjalali

@glemaitre
Copy link
Member Author

Just an example to show that it works:

image

Charlie-XIAO
Charlie-XIAO approved these changes May 19, 2024
View reviewed changes
Copy link
Contributor

@Charlie-XIAO Charlie-XIAO left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks very much.

@Charlie-XIAO Charlie-XIAO merged commit 3191599 into scikit-learn:new_web_theme May 19, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Charlie-XIAO Charlie-XIAO Charlie-XIAO approved these changes

Assignees
No one assigned
Labels
No Changelog Needed
Projects
Documentation improvement
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glemaitre @Charlie-XIAO