Skip to content

DOC fix APIs marked incorrectly as deprecated #29059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2024

Conversation

Charlie-XIAO
Copy link
Contributor

image

I'm sorry that I forgot to remove the deprecations above in #28428 (they were only for testing purposes). They ARE NOT DEPRECATED. @glemaitre I think this needs to be merged quickly.

Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: eb03807. Link to the linter CI: here

Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem. I activate the auto-merge.

@glemaitre glemaitre enabled auto-merge (squash) May 21, 2024 06:51
@glemaitre glemaitre merged commit 24b6779 into scikit-learn:main May 21, 2024
32 checks passed
@Charlie-XIAO Charlie-XIAO deleted the emergence-fix-api branch May 21, 2024 08:51
@Charlie-XIAO
Copy link
Contributor Author

This PR also needs to be backported to the v1.5.x branch otherwise we have incorrect APIs for the 1.5 docs.

@Charlie-XIAO Charlie-XIAO added the To backport PR merged in master that need a backport to a release branch defined based on the milestone. label May 24, 2024
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Jul 2, 2024
@jeremiedbb jeremiedbb mentioned this pull request Jul 2, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation No Changelog Needed To backport PR merged in master that need a backport to a release branch defined based on the milestone.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants