Skip to content

BLD Fix another meson.build dependency #29068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2024

Conversation

lesteve
Copy link
Member

@lesteve lesteve commented May 21, 2024

Yet another instance of #28820

One way to reproduce locally is to start a build from scratch and build specific files that are missing dependencies:

rm -rf my-build
meson setup my-build
ninja -C my-build \
    sklearn/neighbors/_kd_tree.cpython-312-x86_64-linux-gnu.so.p/sklearn/neighbors/_kd_tree.pyx.c

On main you get the following error:

FAILED: sklearn/neighbors/_kd_tree.cpython-312-x86_64-linux-gnu.so.p/sklearn/neighbors/_kd_tree.pyx.c 
cython -M --fast-fail -3 '-X language_level=3' '-X boundscheck=False' '-X wraparound=False' '-X initializedcheck=False' '-X nonecheck=False' '-X cdivision=True' '-X profile=False' --include-dir /home/lesteve/dev/scikit-learn/my-build sklearn/neighbors/_kd_tree.pyx -o sklearn/neighbors/_kd_tree.cpython-312-x86_64-linux-gnu.so.p/sklearn/neighbors/_kd_tree.pyx.c

Error compiling Cython file:
------------------------------------------------------------
...
from libc.string cimport memcpy

import numpy as np
import warnings

from ..metrics._dist_metrics cimport (
^
------------------------------------------------------------

sklearn/neighbors/_binary_tree.pxi:148:0: 'sklearn/metrics/_dist_metrics.pxd' not found

Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: e7feaf0. Link to the linter CI: here

@lesteve lesteve changed the title BLD Fix another Meson dependency BLD Fix another meson.build dependency May 21, 2024
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense. Thanks for the documenting the debugging procedure.

@ogrisel ogrisel added the Quick Review For PRs that are quick to review label May 21, 2024
Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jeremiedbb jeremiedbb merged commit 6614f75 into scikit-learn:main May 22, 2024
43 checks passed
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Jul 2, 2024
@jeremiedbb jeremiedbb mentioned this pull request Jul 2, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build / CI module:neighbors Quick Review For PRs that are quick to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants