Skip to content

DOC do not recommend a particular Python version #29071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ogrisel
Copy link
Member

@ogrisel ogrisel commented May 21, 2024

I find it weird to recommend to use the oldest supported Python version when building from source.

But also recommending the last Python version might be problematic if not all dependencies are packaged on conda-forge right after a new Python release.

So maybe let's not recommend any particular Python version and let the conda command decide based on whats available on conda-forge.

This way we just have to update this doc when bumping up the min version of Python.

@ogrisel ogrisel added the Quick Review For PRs that are quick to review label May 21, 2024
Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 7f66bfe. Link to the linter CI: here

Copy link
Member

@lucyleeow lucyleeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@betatim betatim merged commit a3278af into scikit-learn:main May 22, 2024
34 checks passed
@betatim betatim deleted the doc-build-from-source-python-version branch May 22, 2024 08:01
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Jul 2, 2024
@jeremiedbb jeremiedbb mentioned this pull request Jul 2, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Quick Review For PRs that are quick to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants