FIX Fix GridSearchCV regression in 1.5 with parameter grid with heterogeneous parameter values #29078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have added a test based on the original report. I also added a changelog, but there is definitely some room for improvement. |
3 tasks
|
Thanks! Ran into this today |
Jacob-Stevens-Haas
added a commit
to dynamicslab/pysindy
that referenced
this pull request
May 29, 2024
Arviz uses scipy.signal.gaussian, which was removed in 1.13. Most recent arviz uses scipy.signal.windows.gaussian scikit-learn 1.5.0 contained a regression (scikit-learn/scikit-learn#28352) that has been fixed in scikit-learn/scikit-learn#29078
Jacob-Stevens-Haas
added a commit
to dynamicslab/pysindy
that referenced
this pull request
May 29, 2024
* BLD: Fix broken versions Arviz uses scipy.signal.gaussian, which was removed in 1.13. Most recent arviz uses scipy.signal.windows.gaussian scikit-learn 1.5.0 contained a regression (scikit-learn/scikit-learn#28352) that has been fixed in scikit-learn/scikit-learn#29078 * BLD: Chasing errors, limit scipy/arviz in SBR To test the notebooks, need to install SBR extras, which included a version of arviz that isn't available on 3.9. Earlier version works, but restricts scipy version
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Jul 2, 2024
…eous parameter values (scikit-learn#29078)
jeremiedbb
pushed a commit
that referenced
this pull request
Jul 2, 2024
…eous parameter values (#29078)
twhsu-stanley
pushed a commit
to twhsu-stanley/pysindy
that referenced
this pull request
Oct 29, 2024
* BLD: Fix broken versions Arviz uses scipy.signal.gaussian, which was removed in 1.13. Most recent arviz uses scipy.signal.windows.gaussian scikit-learn 1.5.0 contained a regression (scikit-learn/scikit-learn#28352) that has been fixed in scikit-learn/scikit-learn#29078 * BLD: Chasing errors, limit scipy/arviz in SBR To test the notebooks, need to install SBR extras, which included a version of arviz that isn't available on 3.9. Earlier version works, but restricts scipy version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fix #29074
What does this implement/fix? Explain your changes.
np.result_typecan raiseValueErrorin some cases e.g.np.result_type(None, {'a': '1'}). In that case we should use dtype object.I haven't added a test yet but will do soon.A test has been added.