DOC temporary fix for search summary #29090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrinjalali
approved these changes
May 23, 2024
There was a problem hiding this comment.
I concur that this fixes the issue. I wouldn't have minded waiting for the release as @glemaitre mentioned. But since we have now this PR, we can also merge and push to the 1.5 branch as well.
|
We could therefore backport this fix to the stable branch. |
|
sphinx-pydata-theme 0.15.3 has been released, I think we should revert this PR. |
|
I think it is not available on the |
|
Indeed the conda-forge feedstock PR hasn't been merged yet and its CI is failing: conda-forge/pydata-sphinx-theme-feedstock#52 |
|
#29134 reverts this PR, bumps the version, and makes fixes according to the new theme. |
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Jul 2, 2024
jeremiedbb
pushed a commit
that referenced
this pull request
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29073.
This is a temporary workaround. It overwrites the default
searchtools.jsby copying a vendoredsearchtools.jswith the same name into the static directory. The vendoredsearchtools.jsreplaces all occurrences of[role="main"]with#main-content, becausepydata-sphinx-theme==0.15.2has<main id="main-content" class="bd-main">without therole="main".After
pydata-sphinx-theme==0.15.3is release we can bump the minimum version ofpydata-sphinx-themeto0.15.3and simply removed this vendored file.