Skip to content

MNT remove deprecated loss_function_ in SGD #29095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 28, 2024
Merged

MNT remove deprecated loss_function_ in SGD #29095

merged 3 commits into from
Jun 28, 2024

Conversation

lorentzenchr
Copy link
Member

Reference Issues/PRs

Remove deprecated loss_function_ attribute of SGD classes, see #27979 and #29088.
Contributes to #28049.

What does this implement/fix? Explain your changes.

Any other comments?

@github-actions GitHub Actions
Copy link

github-actions bot commented May 24, 2024 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 5ae94e7. Link to the linter CI: here

@lorentzenchr lorentzenchr added this to the 1.6 milestone Jun 17, 2024
thomasjpfan
thomasjpfan reviewed Jun 21, 2024
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a merge conflict in this PR.

Normally, we wait closer to the release before removing deprecated things. It makes it easier to back port bug fixes. But I think this PR is okay to merge earlier because it's small scope.

@lorentzenchr lorentzenchr mentioned this pull request Jun 24, 2024
Closed
thomasjpfan
thomasjpfan reviewed Jun 24, 2024
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI error looks real. Removing the following should fix it:

https://github.com/lorentzenchr/scikit-learn/blob/535a83949651a5c4ca9fa75aba091a031205b9be/sklearn/linear_model/_perceptron.py#L126-L128

OmarManzoor
OmarManzoor approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OmarManzoor OmarManzoor merged commit b679062 into scikit-learn:main Jun 28, 2024
30 checks passed
@lorentzenchr lorentzenchr deleted the mnt_dep_loss_function_ branch June 28, 2024 06:27
@jeremiedbb jeremiedbb mentioned this pull request Jul 2, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

@OmarManzoor OmarManzoor OmarManzoor approved these changes

Assignees
No one assigned
Labels
module:linear_model No Changelog Needed
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.
3 participants
@lorentzenchr @thomasjpfan @OmarManzoor