Avoid incorrect "Unsupported device for NumPy"; fixes #29107 #29108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids incorrect `ValueError: Unsupported device for NumPy: device(type='cpu')` by using `type` attr if available.
jph00
commented
May 25, 2024
|
I would rather not have any PyTorch-specific assumptions and instead try to find a way to fix this in a way that sticks to what is standardized in the array API spec. Let's first craft minimal reproducer in the original issue to see what needed and then use that as a non-regression test. |
|
Closing in favor of #29119. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids incorrect
ValueError: Unsupported device for NumPy: device(type='cpu')by usingtypeattr if available.Reference Issues/PRs
Fixes #29107
What does this implement/fix? Explain your changes.
Avoids incorrect
ValueError: Unsupported device for NumPy: device(type='cpu')