Skip to content

ENH Test Array API compatibility for paired_cosine_distances #29112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 7, 2024
Merged

ENH Test Array API compatibility for paired_cosine_distances #29112

merged 4 commits into from
Jun 7, 2024

Conversation

EdAbati
Copy link
Contributor

@EdAbati EdAbati commented May 26, 2024

Reference Issues/PRs

Towards #26024

What does this implement/fix? Explain your changes.

paired_cosine_distances seems already compatible with the Array API. I am just adding the test

@github-actions GitHub Actions
Copy link

github-actions bot commented May 26, 2024 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 0a73cc3. Link to the linter CI: here

@EdAbati
Copy link
Contributor Author

EdAbati commented May 27, 2024

Tested on my side with mps and with CUDA and it looks green ✅

@EdAbati EdAbati marked this pull request as ready for review May 27, 2024 06:37
@EdAbati
Copy link
Contributor Author

EdAbati commented May 30, 2024

FYI @OmarManzoor @ogrisel :)

OmarManzoor
OmarManzoor approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @EdAbati

ogrisel
ogrisel approved these changes Jun 7, 2024
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well.

@ogrisel ogrisel enabled auto-merge (squash) June 7, 2024 10:20
@ogrisel ogrisel merged commit 5bc86b8 into scikit-learn:main Jun 7, 2024
28 checks passed
@EdAbati EdAbati deleted the paired-cosine-dist-array-api branch June 7, 2024 16:32
@jeremiedbb jeremiedbb mentioned this pull request Jul 2, 2024
Merged
11 tasks
@OmarManzoor OmarManzoor mentioned this pull request Sep 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@OmarManzoor OmarManzoor OmarManzoor approved these changes

Assignees
No one assigned
Labels
Array API module:metrics
Projects
Array API
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EdAbati @ogrisel @OmarManzoor