Skip to content

DOC Removing warnings from plot_sgd_iris example #29121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2024
Merged

DOC Removing warnings from plot_sgd_iris example #29121

merged 1 commit into from
May 28, 2024

Conversation

ojoaomorais
Copy link
Contributor

Reference Issues/PRs

#29055

What does this implement/fix? Explain your changes.

Removing warnings from plot_sgd_iris example (#29055)

Any other comments?

Acording with the matplotlib Docs:

cmapstr or Colormap, default:rcParams["image.cmap"] (default: 'viridis')
The Colormap instance or registered colormap name used to map scalar data to colors.
This parameter is ignored if c is RGB(A).

@github-actions GitHub Actions
Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 0894d42. Link to the linter CI: here

Charlie-XIAO
Charlie-XIAO approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@Charlie-XIAO Charlie-XIAO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the generated artifacts and this indeed removes the warning.

LGTM, thanks @ojoaomorais!

@Charlie-XIAO Charlie-XIAO merged commit 8798dfe into scikit-learn:main May 28, 2024
33 checks passed
@Charlie-XIAO Charlie-XIAO mentioned this pull request May 28, 2024
Closed
7 tasks
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Jul 2, 2024
@ojoaomorais @jeremiedbb
DOC Removing warnings from plot_sgd_iris example (scikit-learn#29121)
62124b6
@jeremiedbb jeremiedbb mentioned this pull request Jul 2, 2024
Merged
11 tasks
jeremiedbb pushed a commit that referenced this pull request Jul 2, 2024
@ojoaomorais @jeremiedbb
DOC Removing warnings from plot_sgd_iris example (#29121)
163b4ed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Charlie-XIAO Charlie-XIAO Charlie-XIAO approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ojoaomorais @Charlie-XIAO