-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
MAINT Drop official PyPy support #29128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT Drop official PyPy support #29128
Conversation
f4dae1a
to
0a8d083
Compare
…nto drop-official-pypy-support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a good move. We can always fish things back out of the archive to re-add pypy support (in the sense of "might work or not, fix PRs welcome") if we get contacted by people who rely on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at this PR makes me realize we REALLY don't support PyPy. So I'm very happy to not mislead people that we somewhat do.
Thank you, @lesteve. 🙏 |
As discussed at the developer meeting.
Close #27662, close #28956.
Here is a summary of the motivations:
There is very little scikit-learn + PyPy usage
@mattip
.py37hca48384_0
in its filename (mamba create -n pypy scikit-learn
tells you this) and has been downloaded ~2000 times to be compared to the other downloads that amounts to ~3 million downloads.Maintenance has a cost
Changes in this PR
As things stand in this PR, PyPy is mentioned only in the FAQ, some old changelog,
setup.py
(no need to tweak this sincesetup.py
will go away soonish), and becausesklearn.utils.IS_PYPY
is deprecated and scheduled to be removed in scikit-learn 1.7: