MAINT Add user-friendly error when build dependencies are not satifisfied #29132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmm it looks like you need pip recent enough to have
|
adrinjalali
approved these changes
Jun 3, 2024
|
@jeremiedbb would you have time to have a look? |
|
This PR doesn't prevent us from also merging #28721. I find this one uncontroversial and already an improvement so let's merge it first. |
jeremiedbb
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an arguably simpler alternative to #28721 which is adding checks inside
meson.buildwhich is a bit cumbersome.The downside of this PR is that checks are only done when using
--check-build-dependenciesin thepipcommand, which is easy to forget and makes thepipcommand even longer and harder to remember. If you forget to pass--check-build-dependencies, you may have hard to diagnose compilation errors for example because cython is slightly too old (we want the latest release 3.0.10 at the time of writing).Personally I would slightly lean towards #28721 since you can build scikit-learn via
mesonwithout going througpip(meson setup build+ninja -C build+ addbuildfolder toPYTHONPATH). At the same time I would agree that 99% of the usage go throughpipright now, so this is probably good enough.cc @jeremiedbb who was not a fan of #28721 approach.