Skip to content

ENH Add Array Api compatibility for mean_squared_error #29142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 6, 2024
Merged

ENH Add Array Api compatibility for mean_squared_error #29142

merged 9 commits into from
Jun 6, 2024

Conversation

Tialo
Copy link
Contributor

@Tialo Tialo commented May 30, 2024

Towards #26024

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Any other comments?

@github-actions GitHub Actions
Copy link

github-actions bot commented May 30, 2024 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: a2d5a34. Link to the linter CI: here

OmarManzoor
OmarManzoor approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@OmarManzoor OmarManzoor left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @Tialo.

I verified that the tests pass with cuda and mps devices.

ogrisel
ogrisel reviewed Jun 6, 2024
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but let's see if the tests pass on CUDA GPUs with the following manually triggered CI run on our new CUDA CI infrastructure:

https://github.com/scikit-learn/scikit-learn/actions/runs/9399022364

@ogrisel
Copy link
Member

ogrisel commented Jun 6, 2024

For information, I tested locally with on Apple M1 to check the device="mps" case and the test passes:

sklearn/metrics/tests/test_common.py::test_array_api_compliance[mean_squared_error-check_array_api_regression_metric-torch-mps-float32] PASSED

@ogrisel
Copy link
Member

ogrisel commented Jun 6, 2024

I indeed forgot to merge main before triggering the CUDA GPU CI. Let me try again with the new state of the PR:

ogrisel
ogrisel approved these changes Jun 6, 2024
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM CUDA tests are green, thanks for the PR.

@ogrisel ogrisel enabled auto-merge (squash) June 6, 2024 12:20
@ogrisel ogrisel merged commit 08de29d into scikit-learn:main Jun 6, 2024
28 checks passed
@Tialo Tialo deleted the array-api/mean_squared_error branch June 6, 2024 13:04
@ogrisel ogrisel mentioned this pull request Jun 6, 2024
Open
@Tialo Tialo mentioned this pull request Jun 6, 2024
Merged
@jeremiedbb jeremiedbb mentioned this pull request Jul 2, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@OmarManzoor OmarManzoor OmarManzoor approved these changes

Assignees
No one assigned
Labels
Array API module:metrics
Projects
Array API
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tialo @ogrisel @OmarManzoor