-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
DOC tweak appearance of installation instructions #29160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks this looks a lot better to me! A couple of comments.
Sorry for the very late reply.
I don't think substitutions work for multiline, but yes
Changed "Packager" to "Package Manager" as suggested and "OS" to "Operating System" to have a similar length. Long names don't fit well into the same line on small screens so they are only displayed for screen width larger than
I did try in my initial rework of the installation page here, but here since we don't have full control of how things are rendered and sphinx-design has those synchonized tabs things etc., it would be harder to correctly override the behavior with JavaScript but I will give it a try. |
OK thanks, to be honest, since you have tried already and it does indeed look quite painful, then let's drop this this is not so crucial. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the rendered doc is here for a second review
Edit: I pushed a packager -> package-manager in the rst, hopefully I did not break anything.
I think the failing tests were unrelated to this PR, probably due to #29100. |
Yeah you will need to merge main when #29328 is auto-merged 😓 |
In it goes, thanks a lot @Charlie-XIAO! I wished Github has some kind of feature like "merge this in 7 days if noone else comments/complaints", so easy to forget completely fine PRs like this one ... |
Indeed I was looking at the wrong CircleCI artifact sorry for that 😅 ... |
Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
Fixes #29152. This PR mainly:
https://output.circle-artifacts.com/output/job/e64b46ad-9ed6-410e-8f02-35157656fc21/artifacts/0/doc/install.html
Installing.scikit-learn.scikit-learn.1.6.dev0.documentation.16.-.-.Microsoft.Edge.2024-06-03.01-36-08.mp4