-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
🔒 🤖 CI Update lock files for main CI build(s) 🔒 🤖 #29166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
scikit-learn-bot
wants to merge
1
commit into
scikit-learn:main
from
scikit-learn-bot:auto-update-lock-files-main
Closed
🔒 🤖 CI Update lock files for main CI build(s) 🔒 🤖 #29166
scikit-learn-bot
wants to merge
1
commit into
scikit-learn:main
from
scikit-learn-bot:auto-update-lock-files-main
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28853e8
to
c2727ea
Compare
c2727ea
to
ce5cfb5
Compare
Looks like a polars update 0.20.29 -> 0.20.31 broke something cc @MarcoGorelli in case you have any insights?
|
Hey Looks like it's due to this change: pola-rs/polars#16520 0.20.30: In [2]: df = pl.DataFrame({'a': [1,2,3], 'b': [4,5,6], 'group': ['a', 'a', 'b']})
In [3]: df[[]]
Out[3]:
shape: (0, 0)
┌┐
╞╡
└┘ 0.20.31: In [17]: df = pl.DataFrame({'a': [1,2,3], 'b': [4,5,6], 'group': ['a', 'a', 'b']})
In [18]: df[[]]
Out[18]:
shape: (0, 3)
┌─────┬─────┬───────┐
│ a ┆ b ┆ group │
│ --- ┆ --- ┆ --- │
│ i64 ┆ i64 ┆ str │
╞═════╪═════╪═══════╡
└─────┴─────┴───────┘ |
ce5cfb5
to
3b49d2b
Compare
I'll have a look at the regression and propose a fix. /take |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update lock files.
Note
If the CI tasks fail, create a new branch based on this PR and add the required fixes to that branch.