Skip to content

MAINT Remove unused targets from Makefile #29170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

lesteve
Copy link
Member

@lesteve lesteve commented Jun 3, 2024

  • ctags, no scikit-learn developers use this. This was a thing for code navigation before LSP (Language Server Protocol) existed, or most people switched to Visual Studio Code or similar.
  • trailing-spaces or code-analysis are probably done through pre-commit with ruff.

Context (if you are curious): I am looking at what could be useful to implement with spin: #29012 and decided I may as well first remove unused targets from the Makefile.

@lesteve lesteve added the Quick Review For PRs that are quick to review label Jun 3, 2024
Copy link

github-actions bot commented Jun 3, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 123615a. Link to the linter CI: here

@jeremiedbb jeremiedbb merged commit bffa460 into scikit-learn:main Jun 4, 2024
44 checks passed
@jeremiedbb jeremiedbb mentioned this pull request Jul 2, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Quick Review For PRs that are quick to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants