Skip to content

DOC Remove warnings from plot svm margin examples #29178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

DOC Remove warnings from plot svm margin examples #29178

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jun 4, 2024

Reference Issues/PRs

#29055

What does this implement/fix? Explain your changes.

Removing warnings from plot svm margin examples

Copy link

github-actions bot commented Jun 4, 2024

❌ Linting issues

This PR is introducing linting issues. Here's a summary of the issues. Note that you can avoid having linting issues by enabling pre-commit hooks. Instructions to enable them can be found here.

You can see the details of the linting issues under the lint job here


black

black detected issues. Please run black . locally and push the changes. Here you can see the detected issues. Note that running black might also fix some of the issues which might be detected by ruff. Note that the installed black version is black=24.3.0.


--- /home/runner/work/scikit-learn/scikit-learn/examples/svm/plot_svm_margin.py	2024-06-04 13:32:26.567292+00:00
+++ /home/runner/work/scikit-learn/scikit-learn/examples/svm/plot_svm_margin.py	2024-06-04 13:32:36.477214+00:00
@@ -63,13 +63,11 @@
         facecolors="none",
         zorder=10,
         edgecolors="k",
         cmap=plt.get_cmap("RdBu"),
     )
-    plt.scatter(
-        X[:, 0], X[:, 1], c=Y, zorder=10, cmap=plt.get_cmap("RdBu")
-    )
+    plt.scatter(X[:, 0], X[:, 1], c=Y, zorder=10, cmap=plt.get_cmap("RdBu"))
 
     plt.axis("tight")
     x_min = -4.8
     x_max = 4.2
     y_min = -6
would reformat /home/runner/work/scikit-learn/scikit-learn/examples/svm/plot_svm_margin.py

Oh no! 💥 💔 💥
1 file would be reformatted, 926 files would be left unchanged.

Generated for commit: e63fbfe. Link to the linter CI: here

@ArturoAmorQ
Copy link
Member

Thanks for your contribution @sacky3105. Unfortunately I will have to close this PR as a duplicate for #29187, where the warning was actually solved (parameter cmap was raising the warning, not edgecolors nor linestyles).

@ArturoAmorQ ArturoAmorQ closed this Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants