Skip to content

MAINT Update pyodide to 0.26.0 #29181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2024
Merged

MAINT Update pyodide to 0.26.0 #29181

merged 1 commit into from
Jun 5, 2024

Conversation

thomasjpfan
Copy link
Member

Currently, the scikit-learn version on pyodide is 1.3.1. This PR updates pyodide to 0.26.0, which should have 1.4.0.

I do not think pyodide/pyodide@ff3942e is released yet to include 1.5.0

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 3c50fe7. Link to the linter CI: here

@betatim
Copy link
Member

betatim commented Jun 4, 2024

Next: using cibuildwheel to make a wheel that is built off of main pypa/cibuildwheel#1456

@lesteve
Copy link
Member

lesteve commented Jun 5, 2024 •
edited
Loading

Nice, thanks a lot! It was on my TODO list but I am glad someone else did it!

Next: using cibuildwheel to make a wheel that is built off of main pypa/cibuildwheel#1456

Unfortunately there is a bug when using Scipy in a Pyodide venv (which is what cibuildwheel is doing). You still need a js wrapper script for now. See #29156 where I double checked this, so for now we can not really use cibuildwheel I think.

@lesteve lesteve merged commit 52b9e2b into scikit-learn:main Jun 5, 2024
33 checks passed
@lesteve
Copy link
Member

lesteve commented Jun 5, 2024

Merger remorse 😅, a commit with [pyodide] would have been nice to trigger a Pyodide build in this PR and double-check that everything was working as expected. I am reasonably confident everything will be fine, but let's see what tomorrow scheduled Pyodide CI will say about this.

jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Jul 2, 2024
@thomasjpfan @jeremiedbb
MAINT Update pyodide to 0.26.0 (scikit-learn#29181)
ae1fada
@jeremiedbb jeremiedbb mentioned this pull request Jul 2, 2024
Merged
11 tasks
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Jul 2, 2024
@thomasjpfan @jeremiedbb
MAINT Update pyodide to 0.26.0 (scikit-learn#29181)
b176d5a
jeremiedbb pushed a commit that referenced this pull request Jul 2, 2024
@thomasjpfan @jeremiedbb
MAINT Update pyodide to 0.26.0 (#29181)
d29b2a0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betatim betatim betatim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomasjpfan @betatim @lesteve